Update Function Arguments in ?gees, ?geesx, ?gges, ?ggesx, and ?gges3
#1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hmmm.. I used flang 21.1.6 on MacOS Ventura 13.7.8 to check what wrong in CI, and all tests were passed. Configure command: testing: Where I can find where LAPACK calls are located? |
Author
|
Call tree looks valid. I have no idea why test failed. |
Author
|
@langou, could you please add |
Contributor
|
I added one for .github/workflows/cmake.yml (seems like other 'ctest' had it.) |
Author
What is about continuous-integration/appveyor/pr? |
Author
|
Ok. Found where it is :-) |
Author
|
No, I definitely has no idea why appveyor fails. |
foxtran
force-pushed
the
update/function-arguments
branch
2 times, most recently
from
53c4803 to
efe84a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using external keyword for Function Arguments, this PR introduces explicit interfaces for Function Arguments. The code should be more safe now, and source code reflect documented behaviour. Later, it will help a lot to generate proper interfaces for these functions.
BIND(C) is used since code can be called from other than Fortran languages.
Checklist